chore(storage): add Bucket Get & Delete implementations #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
BrennaEpp
reviewed
Mar 22, 2022
| req.UserProject(s.userProject) | ||
| } | ||
|
|
||
| return run(ctx, func() error { return req.Context(ctx).Do() }, s.retry, s.idempotent) |
There was a problem hiding this comment.
How do the settings know the default idempotency value for this delete operation?
There was a problem hiding this comment.
Communicating the idempotency will the responsibility of the transport-agnostic client layer (i.e. the layer above these transport-specific implementations that will call them). It will communicate to this transport-specific layer via the storageOption.idempotent(bool). This is basically the same as it is today, where the transport-agnostic client layer supplies true or false to the run call. Swap out the run call for the transport-client interface call with the option idempotent(true) and we are good to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements both gRPC & HTTP Bucket Get & Delete methods, including basic emulator tests.
Also adds a helper,
applyBucketCondsProto, that applies the givenBucketConditionsto an arbitrary protobuf Message that satisfies the documented field requirements. This uses the same strategy as theapplyCondsProtohelper for theConditionstype.